You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the storybook install to the new version, v8, and updates stories to the new format. This is a prerequisite for implementing the design-system, as we want to use the new storybook inheritance and visual testing suite.
Security
REMINDER: All file contents are public.
I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
These changes do not introduce any security risks, or any such risks have been properly mitigated.
Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
I have added relevant Storybook updates to this PR as well.
If this feature requires a developer doc update, tag @CareEvolution/api-docs.
Consider "Squash and merge" as needed to keep the commit history reasonable on main.
Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:
2, because the PR primarily involves version updates and straightforward changes to configuration and documentation files. The changes are mostly clear and well-documented, making the review process less complex.
🧪 Relevant tests
No
⚡ Possible issues
Possible Dependency Issue: The addition of new Storybook addons (@storybook/addon-mdx-gfm and @storybook/addon-webpack5-compiler-babel) should be checked for compatibility with existing project dependencies and configurations to avoid conflicts or runtime errors.
🔒 Security concerns
No
Code feedback:
relevant file
.storybook/main.js
suggestion
Consider verifying the compatibility of newly added Storybook addons with the existing project setup. This is important to ensure that the new addons do not introduce any build or runtime issues. [important]
Ensure that all newly added or updated Storybook packages (@storybook/addon-mdx-gfm, @storybook/addon-webpack5-compiler-babel, etc.) are compatible with other project dependencies. This can prevent potential issues from incompatible package versions. [important]
Review the CSS changes for potential impacts on layout and styling across different browsers, especially the changes in media queries and grid settings. This helps ensure consistent UI/UX in various environments. [medium]
Check the updated import path for Meta from @storybook/blocks to ensure it aligns with the new Storybook documentation and functionality, as import paths can often lead to breaking changes if not correctly updated. [important]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates the storybook install to the new version, v8, and updates stories to the new format. This is a prerequisite for implementing the design-system, as we want to use the new storybook inheritance and visual testing suite.
Security
REMINDER: All file contents are public.
Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
Checklist
Testing
Documentation
Consider "Squash and merge" as needed to keep the commit history reasonable on
main.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including: